Add support for key_set qualifier #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulienBortolussiAda
requested review from
Nikokrock,
grouigrokon and
liaiss
|
Maybe I could add a way to set the separator |
liaiss
reviewed
Sep 19, 2023
liaiss
reviewed
Sep 19, 2023
liaiss
reviewed
Sep 19, 2023
JulienBortolussiAda
force-pushed
the
add_key_set_qualifier
branch
from
8dbbf3a to
f898c2b
Compare
liaiss
reviewed
Sep 20, 2023
Nikokrock
reviewed
Sep 27, 2023
JulienBortolussiAda
force-pushed
the
add_key_set_qualifier
branch
from
f898c2b to
9cda174
Compare
Nikokrock
reviewed
Oct 3, 2023
src/e3/anod/qualifiers_manager.py
Outdated
| """See QualifierDeclaration.default.""" | ||
| return self._default | ||
|
|
||
| def value(self, value: str | bool | frozenset[str]) -> str | bool | frozenset[str]: |
There was a problem hiding this comment.
there is no case in which a frozen set is accepted as input
There was a problem hiding this comment.
I have also remove bool for the same reason. If I missed something, let me know.
key_set qualifiers expect semi-colon separated list as value.
JulienBortolussiAda
force-pushed
the
add_key_set_qualifier
branch
from
9cda174 to
133e73c
Compare
Nikokrock
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
key_set qualifiers expect semi-colon separated list as value.
#630