Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ana Lisa Sutherland: Octos Static Site #41

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

The-Beez-Kneez
Copy link

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? Really, being able to interpret if I was using the HTML Validator correctly. And how to go back through and carefully change the portions that were indicated.
Why is it important to consider and use semantic HTML? This allows the HTML documents to be composed much like they will be read. This is crucial for people who use viewing/listening aid programs to interact with web pages.
How did you decide to structure your CSS?
I took a large inspiration off of the live code, and tried not to be too disappointed that I was unable to do more with the site. It is simple and composed of simple pages with mainly large blocks of text. But that is what I can comfortably use my new knowledge for, so I did that.
What was the most challenging piece of this assignment?
The CSS styling was very difficult, the flex and grid configurations in particular. I am still unsure if my final page ended up in the layout I wanted.
Describe one area that you gained more clarity on when completing this assignment
Optional
The structuring of HTML documents makes a lot of sense to me, more so now that I was made to design my own baby page. It really does flow like a book and is easily readable once you realize that.
Did you deploy to GitHub Pages? If so, what is the URL to your website?
I did not deploy it to GitHub Pages.
Overall

@tildeee
Copy link

tildeee commented Apr 5, 2018

Personal Portfolio Site

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage x. Small note, but in one commit message, you say that you didn't have internet connection. You can make commits without internet connection, you just won't be able to push! Also, small note, but you likely don't need to be as specific as to name literal file names, but you can say something like "create the hobbies page"
Answered comprehension questions x, weird format
Page fully loads x
No broken links (regular or images) broken image on the truth page, broken link to LinkedIn
Includes at least 4 pages and styling only 3 pages
HTML
Uses the high-level tags for organization: header, footer, main would have benefited using a main and a footer
Appropriately using semantic tags: section, article, etc. x
All images include alternate text x
CSS
Using class and ID names in style declarations x
Style declarations are DRY Did not ever include more than one stylesheet in one page-- we expected a normalize.css to exist as well as specific page styles. Some of the common styles (styles on body) could have been in one stylesheet (such as main.css), which would be included on all pages.
Overall

The project has a lot of unfinished edges-- we expected 4 pages and I could only navigate to three pages. We wanted to see a normalize.css file used to practice including several stylesheets on a single page.

Also, you have a folder called images-- which includes a css file that has the HTML tag img inside of it. However, you don't have references to try to use it --It seems like this was either you trying to work through something and you abandoned it? I just want to confirm.

You also don't need to push onto GitHub your test pages.

Otherwise, your site is overall fun. Good work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants