Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ampers Lily Sky #2

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Ampers Lily Sky #2

wants to merge 14 commits into from

Conversation

lillers1122
Copy link

@lillers1122 lillers1122 commented Mar 18, 2018

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? Yes...the validator did not like my links for google fonts or my lack of h1 tags at the start of sections.
Why is it important to consider and use semantic HTML? Clarity and consistency.
How did you decide to structure your CSS? I put my basic design ideas in the style.css file and then continued to style each page with its own stylesheet after that.
What was the most challenging piece of this assignment? Getting the design ideas I had to work with mobile - hover states aren't a thing on phones! Who knew?? I do now. Still not satisfied with my final mobile design, but it's okay for now.
Describe one area that you gained more clarity on when completing this assignment I gained more clarity with the nav bar! It would jump when I added padding and stopped only after I removed it...I'm still not entirely sure how to get the spacing consistent on a small screen.
Optional
Did you deploy to GitHub Pages? If so, what is the URL to your website? https://lillers1122.github.io
Overall

@CheezItMan
Copy link

Personal Portfolio Site

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage Good number of commit and good commit messages
Answered comprehension questions Check, spacing on small screens is something to practice on
Page fully loads Check
No broken links (regular or images) Check
Includes at least 4 pages and styling Check
HTML
Uses the high-level tags for organization: header, footer, main Check
Appropriately using semantic tags: section, article, etc. Check
All images include alternate text Your dog is missing an alt attribute.
CSS
Using class and ID names in style declarations Check
Style declarations are DRY Fairly DRY
Overall 1st things 1st. Are you sure you're not a sheep? Nice work making things responsive. You hit all the requirement, nice work!

<main>
<section class="dino">
<p>
<img src="../images/dogg.jpg" />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alt attribute...

}

/* SMALL SCREEN */
@media screen and (max-width: 500px) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice a media query!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants