Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ampers - Maddie Shields #39

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Ampers - Maddie Shields #39

wants to merge 16 commits into from

Conversation

madaleines
Copy link

Hotel

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Describe a design decision you had to make when working on this project. What options were you considering? What helped you make your final decision? So many with when to make a class or not. I decided to make classes for Room and Block and felt I could have not made a class for them. I decided to with in mind if there were different rates or with a possible guest class.
Describe a concept that you gained more clarity on as you worked on this assignment. Blocking rooms was interesting to be able to have a user reserve a room with or without a block_id by means of using a hash to make it optional.
Describe a nominal test that you wrote for this assignment. The reserve room method takes an input of data to make an instance of a reservation
Describe an edge case test that you wrote for this assignment. The reservations needed to be an array as well as increment each time a new reservation was being made.
How do you feel you did in writing pseudocode first, then writing the tests and then the code? Helpful. I notice I draw graphs more with what tasks I want to do that way I can know where to write my pseudocode for it as well

@kariabancroft
Copy link

Hotel

What We're Looking For

Feature Feedback
Design
Demonstrated classes having a single responsibility Yes - nice job using a private method to encapsulate functionality.
Demonstrated loose coupling Yes
Methods demonstrate a good use of encapsulation, inputs and outputs Yes
Wave 1 requirements Yes
Wave 2 requirements Yes
Wave 3 requirements Yes

You did a nice job on this. I'm curious about the tests that you have skipped if you were trying to simplify or if these are broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants