Jade and Mindy - Shipping-Service #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Tested it all out in rails console and everything works, yaaay
Why is this showing :( :( :( It's ignored but still here booooo
…ne written right now
…rror (XML Syntax Error: Please check the XML request to see if it can be parsed.):'
…s. But rates work so kicking it to production
|
Hey y'all, did you deploy this to Heroku? If so, could you provide the link for that? |
| fedex_rates = get_rates(fedex) | ||
|
|
||
| request = [ups, fedex].as_json | ||
| response = [ups_rates, fedex_rates].as_json |
There was a problem hiding this comment.
Did you end up not using usps? If it's not being used in your code, maybe you could comment it out and explain why you wanted to keep it around for future use, or just remove it before the PR?
|
Also, is there a PR for the Betsy part of the project? I looked under Hipsterly, and I only see one PR from the other group. |
| class Carrier < ActiveRecord::Base | ||
| validates :request, presence: true | ||
| validates :response, presence: true | ||
|
|
There was a problem hiding this comment.
You could make this one line by doing validates_presence_of :request, :response if you wanted. Just fyi.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a very challenging project; we learned how to read through someone else's code, build our own API and work with new API's that generally are known for having internal problems ( as per internet results).
I'm really proud of how well we communicated throughout the project, and were able to work through errors while building the connection to the API, and working on different parts of the app simultaneously. We got some really strange errors with the .gitignore file, the api responses and some challenging errors with code that wasn't originally ours. As of now, it's mostly working, and we learned a lot, so that's great ^_^
links: http://suchhipsterly.herokuapp.com/
http://super-sweet-shippers.herokuapp.com/