Nicole & Jess' Shipping API #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there! Me and @TamarHershi will be reviewing your project. Woo hoo! Right off the bat, I'm loling at " Finally got a UPS and USPS account. Only took 24 fucking hours" ha ha ha ha |
| //= require jquery | ||
| //= require jquery_ujs | ||
| //= require turbolinks | ||
| //= require_tree . |
There was a problem hiding this comment.
Remember to delete these files you don't use. Otherwise your code reviewers have to scroll through them :(
| render json: estimate.as_json, :status => :ok | ||
| rescue ActiveShipping::ResponseError | ||
| render json: [], :status => :bad_request | ||
| end |
There was a problem hiding this comment.
Thank you! Charles helped us out with this one, so it's still kinda confusing to me.
|
Overall, great job! You made it look easy 🌟 |
|
Thanks for reviewing everything! 🤗 |
|
Thank you for the feedback!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pair project by Nicole and Jess.
This was hard! But we learned a lot.
Original project and PR for shipping service - sophiabaldonado/betsy#1
Shipping API - http://shipping-traverse.herokuapp.com
Betsy Traverse - http://traverse-shipping.herokuapp.com