Preliminary PR #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| request.get("http://localhost:3000/customers", function(error, response, body) { | ||
| var customers = JSON.parse(body) | ||
| expect(typeof customers).toEqual('object') | ||
| done() |
There was a problem hiding this comment.
Your test description states that this should be an array, but it looks like you are actually verifying that it is an object.
|
Great job on this project! You were really consistent setting up patterns throughout your project and following them through the app. You did an excellent job with error handling and writing tests to ensure your code is behaving as expected. Awesome work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sarah Kane & Justine Winnie
Sarah's going to keep working on this for a bit but I'm doing the PR now for ease since I forked it.
Points of pride:
Sarah learning Istanbul and doing hella testing!
Justine making a dependency injection work!