Jillian & Jade's EXTREME VIDEO EXPRESS (it's the 90s) API!!!!!11!!!!1! kewl. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…son file, started defining our schema, and updated seeds to suit our wants.
…ne was an exercise in understanding.
…the model to customers to better reflect that it is getting customers, not videos
…stomers from videos
…sort to test that it returns the correct number of pages, but I have not yet done that. We should also write tests for errors.
| // database setup | ||
| var connectionString = "postgres://localhost/extreme_video_express"; | ||
| var db = massive.connectSync({connectionString: connectionString}); | ||
| app.set('db', db); |
There was a problem hiding this comment.
I'm so jealous. This project would've helped me so much in my capstone. It took me 2 days to figure out how to set up a database and then connect with it from within my (non rails) app. So yay! This concept is really important :)
|
Sorry I don't have a whole lot to add. I don't do javascript. But it looked good to me! Good job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jade and I had a good time with this project. We are really proud that we completed the requirements (well, almost, one of our models is only at 84% coverage...Testing errors is challenging!), and also the ease we had in understanding the flow of data.
Testing our callback errors was very challenging, and we would like more practice with that. Not fully understanding massive "under the hood" made it difficult to make things fail.