Snow Leopards - Diana S. #167

sorindevops · 2022-09-28T01:54:10Z

No description provided.

marciaga · 2022-09-29T23:49:01Z

play_tester.py

-pp.pprint(HORROR_1)
-pp.pprint(FANTASY_1)
-pp.pprint(FANTASY_2)
+print(create_movie(MOVIE_TITLE_1,GENRE_1,RATING_1))


Just a little FYI, in the future, if you make changes to a sandbox file like this, you don't need to add it to the staging area/commit it and push up the changes.

It's no problem that you did so here since this isn't a PR that will get merged into the project, but if your changes were to be merged into a project then someone reviewing your code would probably ask you to remove these changes from the PR so they don't get merged into the main code base.

marciaga · 2022-09-29T23:49:33Z

tests/test_wave_01.py

@@ -119,12 +119,13 @@ def test_moves_movie_from_watchlist_to_empty_watched():
    assert len(updated_data["watchlist"]) == 0
    assert len(updated_data["watched"]) == 1

-    raise Exception("Test needs to be completed.")
+    # raise Exception("Test needs to be completed.")
+    assert  MOVIE_TITLE_1 == updated_data["watched"][0]["title"]


You could also assert against the genre and rating key/values in the same way, for more thoroughness!

marciaga · 2022-09-29T23:50:37Z

tests/test_wave_01.py

@@ -143,12 +144,13 @@ def test_moves_movie_from_watchlist_to_watched():
    assert len(updated_data["watchlist"]) == 1
    assert len(updated_data["watched"]) == 2

-    raise Exception("Test needs to be completed.")
+    # raise Exception("Test needs to be completed.")
+    assert updated_data["watched"] == [FANTASY_2,HORROR_1]


This definitely works! You could also use in to make the assertions and capture more conditions like:

assert updated_data["watched"][1] == movie_to_watch assert movie_to_watch in updated_data["watched"] assert FANTASY_2 in updated_data["watched"] assert FANTASY_1 in updated_data["watchlist"] assert movie_to_watch not in updated_data["watchlist"]

marciaga · 2022-09-29T23:51:07Z

tests/test_wave_03.py

@@ -55,12 +55,14 @@ def test_friends_unique_movies_not_duplicated():
    # Assert
    assert len(friends_unique_movies) == 3

-    raise Exception("Test needs to be completed.")
+    for movie in friends_unique_movies: 
+        assert movie in [HORROR_1, FANTASY_4, INTRIGUE_3]


marciaga · 2022-09-29T23:54:02Z

tests/test_wave_05.py

@@ -52,13 +52,18 @@ def test_new_genre_rec_from_empty_friends():
            }
        ]
    }
-
-    raise Exception("Test needs to be completed.")
+    # raise Exception("Test needs to be completed.")


This test still has a skip on it and when I ran it, the test failed. I'll leave more detailed comments in Wave 5 in party.py

marciaga · 2022-09-29T23:54:49Z

viewing_party/party.py

@@ -1,23 +1,166 @@
-# ------------- WAVE 1 --------------------
+from pprint import pprint


An extraneous import? Probably auto-imported from VSCode. These unused imports should not be committed. I recommend turning off that setting in VS Code.

marciaga · 2022-09-29T23:55:09Z

viewing_party/party.py

+def _get_movies_watched_by_friends(user_data):
+    movies_watched_by_friends = []
+
+    for friend in user_data["friends"]: #[{}]


Not sure what the purpose of the comment at the end of this line is, but it's safe to delete it.

marciaga · 2022-09-29T23:58:45Z

viewing_party/party.py

+
+    return movies_watched_by_friends
+
+def _get_movies_not_watched_user(user_data):


This function appears to not be used so there's no need to commit it

marciaga · 2022-09-30T00:01:24Z

viewing_party/party.py

+
+    for friend in user_data["friends"]: #[{}]
+        for friend_movie in friend["watched"]: #{}
+            if friend_movie in movies_watched_by_friends:


This conditional could be rewritten to avoid using continue in the if block, I believe as follows:

if friend_movie not in movies_watched_by_friends: movies_watched_by_friends.append(friend_movie)

marciaga · 2022-09-30T00:02:07Z

viewing_party/party.py

+        watchlist_title = movie["title"]
+        if title == watchlist_title:
+            user_data["watchlist"].remove(movie)
+            user_data["watched"].append(movie)


To avoid any potential issues modifying a list that's being iterated on, it's a good idea to break after making that modification.

marciaga · 2022-09-30T00:09:14Z

viewing_party/party.py

+    for movie in user_data["watched"]:
+        rating += movie["rating"]
+
+    if rating == 0:


Great job with this method! Couple of small callouts here.

You could convey intent a little more explicitly by pulling the logic around return 0 into it's own guard clause with (on line 57 so it's the first line of code that executes in this method):

if not user_data["watched"]: return 0

then proceed to build up your rating with the for-loop.

This way, when another developer comes along, I can immediately recognize "Oh if this value doesn't exist, then we'll return 0. The way your code is currently structured, I can tell at some point this method will return 0, but it's not as immediately clear.

Also a note about guard clauses - The Guard Clause pattern helps in these cases by “inverting” that way of thinking and rapidly returning false conditions and keeping the important code blocks (usually the longest) in the lowest indentation level possible

marciaga · 2022-09-30T00:09:37Z

viewing_party/party.py


+
+    favorite_genre = max(set(genre_list), key= genre_list.count) 


Nice use of max here. I find it useful to also practice writing your own implementation of finding a max value from a dictionary. You may find in an interview if you use built in functions like max that an interviewer may ask you how the function works under the hood. So knowing how to write it on your own can help you better understand the function.

marciaga · 2022-09-30T00:10:31Z

viewing_party/party.py

 # -----------------------------------------
 # ------------- WAVE 3 --------------------
 # -----------------------------------------
+def get_unique_watched(user_data):


Good use of helper function!

marciaga · 2022-09-30T00:10:59Z

viewing_party/party.py

+    for friend_movie in movies_watched_by_friends: #user_data = "friends": [{}]
+        if friend_movie not in user_watched_movies:
+            recommended_movies.append(friend_movie)
+


Good job with this one!

marciaga · 2022-09-30T00:12:42Z

viewing_party/party.py

+
+    for movie in recommended_movies:
+        if movie["host"] in user_subscriptions:
+            pprint(recommended_movies_subscription.append(movie))


this expression should be taken out of the pprint call

marciaga · 2022-09-30T00:13:36Z

viewing_party/party.py

+        if friend_movie["genre"] == popular_genre:
+            if friend_movie not in user_data["watched"]:
+                list_rec_movies_genre.append(friend_movie)
+    print(list_rec_movies_genre)


It's usually not a good idea to leave print statements in committed code because they're often for debug purposes. It's good to get in the habit of re-reading your PRs to make sure they don't contain things like this.

marciaga · 2022-09-30T00:21:15Z

viewing_party/party.py

+
+
+def get_rec_from_favorites(user_data):
+    list_rec_favorites= []


In order to fix that failing test, using the code in this function, you'll have to guard against the possibility that there's no "favorites" key in the user_data dictionary. There's a dictionary method that returns None if the key doesn't exist, called get. You can use it like so:

if not user_data.get("favorites"): return []

If you use that as the guard clause, then allow that test to run, it should pass.

marciaga · 2022-09-30T00:22:33Z

Great job on your first Unit project, Diana!
Good use of variable names and helper functions as well as some syntax not yet covered in the material. I left some comments on your pull request, mostly suggestions on refactoring opportunities and other things to consider. Great job making many small commits with clear and descriptive messages.

sorindevops added 13 commits September 25, 2022 16:12

Part 2 and 3

79f4cd3

finish part 3

f022a24

finished wv 3

df751a6

wv 4 pending

bc3ccd5

wave 4 completed

57af330

wave 4 comments gone

609561f

Wave 4 tests completed

bdd5cfb

added genres to list w/o being filtered

f79c893

added genres to list w/o being filtered

11aed37

need to fix one more test

e2b225f

need to assert a test

39bb7bb

Wave 5 completed

b39d272

wave 5 cleanup comments

60bd4a7

marciaga reviewed Sep 29, 2022

View reviewed changes

marciaga reviewed Sep 30, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Snow Leopards - Diana S. #167

Snow Leopards - Diana S. #167

sorindevops commented Sep 28, 2022

marciaga Sep 29, 2022

marciaga Sep 29, 2022

marciaga Sep 29, 2022

marciaga Sep 29, 2022

marciaga Sep 29, 2022

marciaga Sep 29, 2022

marciaga Sep 29, 2022

marciaga Sep 29, 2022

marciaga Sep 30, 2022

marciaga Sep 30, 2022

marciaga Sep 30, 2022

marciaga Sep 30, 2022

marciaga Sep 30, 2022

marciaga Sep 30, 2022

marciaga Sep 30, 2022

marciaga Sep 30, 2022

marciaga Sep 30, 2022

marciaga commented Sep 30, 2022

		@@ -1,23 +1,166 @@
		# ------------- WAVE 1 --------------------
		from pprint import pprint


		return movies_watched_by_friends

		def _get_movies_not_watched_user(user_data):



		favorite_genre = max(set(genre_list), key= genre_list.count)



		def get_rec_from_favorites(user_data):
		list_rec_favorites= []

Snow Leopards - Diana S. #167

Are you sure you want to change the base?

Snow Leopards - Diana S. #167

Conversation

sorindevops commented Sep 28, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

marciaga commented Sep 30, 2022