Tigers - Paje Bishop #158
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,23 +1,105 @@ | ||
| def create_movie(title, genre, rating): | ||
| if title and genre and rating: | ||
| movie = {"title": title, "genre": genre, "rating": rating} | ||
| else: | ||
| movie = None | ||
| return movie | ||
|
|
||
| def add_to_watched(user_data, movie): | ||
| user_data["watched"] = [movie] | ||
| return user_data | ||
|
There was a problem hiding this comment. Ah, this is kind of a mistake on our tests but there is a bug here that they don't catch. Line 9 here will replace the entire value of Not too major and sorry for our tests missing it. That being said, usually the expected behavior of adding to a list is to append the new element. There was a problem hiding this comment. Plus you otherwise seem to know how to use |
||
|
|
||
| def add_to_watchlist(user_data, movie): | ||
| user_data["watchlist"] = [movie] | ||
| return user_data | ||
|
There was a problem hiding this comment. The same bug as |
||
|
|
||
| def watch_movie(user_data, movie_title): | ||
| for movies in user_data["watchlist"]: | ||
| if movies["title"] == movie_title: | ||
| user_data["watched"].append(movies) | ||
| user_data["watchlist"].remove(movies) | ||
| return user_data | ||
|
|
||
| # ----------------------------------------- | ||
| # ------------- WAVE 2 -------------------- | ||
| # ----------------------------------------- | ||
| def get_watched_avg_rating(user_data): | ||
| ratings_list = [] | ||
| for movies in user_data["watched"]: | ||
| ratings_list.append(movies["rating"]) | ||
| if ratings_list: | ||
| rating_average = sum(ratings_list)/len(ratings_list) | ||
| else: | ||
| rating_average = 0.0 | ||
| return rating_average | ||
|
|
||
| def get_most_watched_genre(user_data): | ||
| genres = [] | ||
| for movies in user_data["watched"]: | ||
| genres.append(movies["genre"]) | ||
| if genres: | ||
| most_watched_genre = max(genres, key = genres.count) | ||
|
There was a problem hiding this comment. This works, but there's a minor performance hit. Now, as we hadn't even covered time complexity when you wrote this, this is not a major enough problem that I would move away from a Green. But I am pointing it out! |
||
| else: | ||
| most_watched_genre = None | ||
| return most_watched_genre | ||
| # ----------------------------------------- | ||
| # ------------- WAVE 3 -------------------- | ||
| # ----------------------------------------- | ||
| def get_unique_watched(user_data): | ||
| unique_watched = [] | ||
| friends_watched = [] | ||
| for i in range(len(user_data["friends"])): | ||
|
There was a problem hiding this comment. Nothing wrong with using Mostly just a minor style nitpick, though. The same goes for a few other loops here and in |
||
| for item in user_data["friends"][i]["watched"]: | ||
| friends_watched.append(item) | ||
| for movie in user_data["watched"]: | ||
| if movie not in friends_watched: | ||
| unique_watched.append(movie) | ||
| return unique_watched | ||
|
|
||
| def get_friends_unique_watched(user_data): | ||
| friends_watched = [] | ||
| friends_unique_watched = [] | ||
| for i in range(len(user_data["friends"])): | ||
| for item in user_data["friends"][i]["watched"]: | ||
| friends_watched.append(item) | ||
| for movie in friends_watched: | ||
| if (movie not in user_data["watched"] | ||
| and movie not in friends_unique_watched): | ||
| friends_unique_watched.append(movie) | ||
|
|
||
| return friends_unique_watched | ||
|
|
||
| # ----------------------------------------- | ||
| # ------------- WAVE 4 -------------------- | ||
| # ----------------------------------------- | ||
| def get_available_recs(user_data): | ||
| friends_unique_watched = get_friends_unique_watched(user_data) | ||
| reccommendations = [] | ||
| for movie in friends_unique_watched: | ||
| if movie["host"] in user_data["subscriptions"]: | ||
| reccommendations.append(movie) | ||
| print(reccommendations) | ||
|
There was a problem hiding this comment. I'm guessing this print statement was for debugging purposes. Not major, but usually good style to make sure to remove these after you're done debugging. |
||
| return reccommendations | ||
| # ----------------------------------------- | ||
| # ------------- WAVE 5 -------------------- | ||
| # ----------------------------------------- | ||
| def get_new_rec_by_genre(user_data): | ||
| favorite_genre = get_most_watched_genre(user_data) | ||
| friends_movies = get_friends_unique_watched(user_data) | ||
| rec_list_by_genre = [] | ||
| if friends_movies: | ||
| for movie in friends_movies: | ||
| if movie["genre"] == favorite_genre: | ||
| rec_list_by_genre.append(movie) | ||
| else: | ||
| return None | ||
|
There was a problem hiding this comment. Looking at our instructions, I'm reading them as we were expecting that an empty list would be returned in this case, but it's completely legitimate that one would return However not really a fault on your part because it seems we didn't test this case in our tests either! |
||
| return rec_list_by_genre | ||
|
|
||
| def get_rec_from_favorites(user_data): | ||
| user_unique_movies = get_unique_watched(user_data) | ||
| rec_list_from_favorites = [] | ||
| for movie in user_data["watched"]: | ||
| if (movie in user_unique_movies | ||
| and movie in user_data["favorites"]): | ||
| rec_list_from_favorites.append(movie) | ||
| return rec_list_from_favorites | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This assertion is fine as a quick check, but definitely keep in mind that you're not limited to one assert here, and being through in your testing can have benefits. For example, I would at least add assertions to check that the
"title"and"rating"keys are correct too.