Cheetahs - Ariam Y. #111
Open
Cheetahs - Ariam Y. #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goeunpark
reviewed
Dec 19, 2022
There was a problem hiding this comment.
Great job, Ariam! ✨
This website sparked a lot of joy! Your semantic HTML is clear and you squeezed in three website styles in one project. Great work going above and beyond, I think you and CSS will have a beautiful future ahead! This project is a Green. 🟢
Keep it up! 💯
Comment on lines
+4
to
+6
| display: grid; | ||
| grid-template-columns: 20% auto 20%; | ||
| grid-template-rows: .5fr 1fr .25fr; |
Comment on lines
+87
to
+105
| .tags li:nth-of-type(1) { | ||
| background-color: royalblue; | ||
| } | ||
|
|
||
| .tags li:nth-of-type(2) { | ||
| background-color: orange; | ||
| } | ||
|
|
||
| .tags li:nth-of-type(3) { | ||
| background-color: mediumvioletred; | ||
| } | ||
|
|
||
| .tags li:nth-of-type(4) { | ||
| background-color: teal; | ||
| } | ||
|
|
||
| .tags li:nth-of-type(5) { | ||
| background-color: purple; | ||
| } |
Comment on lines
+16
to
+18
| display: flex; | ||
| flex-direction: column-reverse; | ||
|
|
There was a problem hiding this comment.
Great use of flexbox to align this header image! 💯
| text-align: center; | ||
| font-weight: 300; | ||
| color:lavender; | ||
| background-color:whitesmoke |
There was a problem hiding this comment.
Don't forget your ending semicolons! 😉
Comment on lines
+14
to
+15
| <a href="file:///Users/ariamyonas/Developer/projects/personal-portfolio-site/pages/index.html">Home</a> | ||
| <a href="file:///Users/ariamyonas/Developer/projects/personal-portfolio-site/pages/portfolio.html">Portfolio</a> |
There was a problem hiding this comment.
To make these hyperlinks accessible to other folks who pull up your code, we can access them by their relative path, like this:
<a href="index.html">Home</a>
<a href="portfolio.html">Portfolio</a>
Comment on lines
+46
to
+54
| <footer> | ||
| <nav id ='footer-nav'> | ||
| <ul class = 'footer-tags'> | ||
| <li><a href = 'https://github.com/arusphere'>GitHub</a></li> | ||
| <lil><a href = 'https://www.linkedin.com/in/ariam-y-5a8ab4134/'>LinkedIn</a></lil> | ||
| <lil><a href = '[email protected]'>Email</a></lil> | ||
| </ul> | ||
| </nav> | ||
| </footer> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Personal Portfolio Site
Congratulations! You're submitting your assignment!
Comprehension Questions