Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sockets - Evelynn & Nara #5

Open
wants to merge 50 commits into
base: master
Choose a base branch
from
Open

Sockets - Evelynn & Nara #5

wants to merge 50 commits into from

Conversation

bonara
Copy link

@bonara bonara commented Jun 26, 2019

Video Store Consumer

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Paste a link to the PR for your API Pull Request
For each person in your pair, describe something you learned from your partner during this project Nara emphasized considerations about where to keep state in components, and was good about making thoughtful decisions about how to design the logic flow of data in the React app. Evelynn helped me to troubleshoot a state toggle problem I was having when hiding an error modal box.
What was one area of React you gained more clarity on during this assignment? We learned about React Router, which was really interesting!
Describe how you solved the problem of having lists of movies that look mostly the same but have different content We had two different components for Rental Library and Movie Search and these components also held separate components each.
Describe how you handled rentals with React We kept the rental functions in App.js since we had the selectedMovie and selectedCustomer states in the App component. Rental checkout button appears when both movie and customer are selected. When the button is clicked it makes an axios post request to create a rental.
Describe a DOM event your application handled When the user types in the input field for the MovieSearchPage (onChange), the state of the MovieSearchPage's query attribute is updated.
Did you use any functional stateless components? What for? We used functional stateless components for Movie, Customer and Search Result since we weren't keep track of any states in these components.
Did you use any container components? What for? The RentalLibraryPage and CustomerListPage are used for routing and containing the lists of customers and movies in the library.
Do you have any recommendations on how we could improve this project for the next cohort? The way that the image URLs are constructed in the movie_wrapper in the scaffolded Rails API causes image URLs to be broken when adding a movie to the library because the Rails API sends over a full image URL to React, which spits back full URL...but the API is only expecting a path without a base URL. We added a simple conditional to that scaffolded method to fix the bug but it would be worth considering for next cohort!

bonara and others added 30 commits June 24, 2019 14:57
…non-form input and button from a submit to a regular button
…tion to add a search result to the rental library
@bonara bonara changed the title Sockets - Evelynn && Nara Sockets - Evelynn & Nara Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants