Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ports - Shamira, Ngoc, Elle #28

Open
wants to merge 51 commits into
base: master
Choose a base branch
from
Open

Conversation

dev-elle-up
Copy link

@dev-elle-up dev-elle-up commented Jun 28, 2019

Video Store Consumer

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Paste a link to the PR for your API Ada-C11/VideoStoreConsumer-API#20
For each person in your pair, describe something you learned from your partner during this project Shamira: Learned more about passing props. Elle: I learned generally how the React Router works. Ngoc: Details on using Postman, especially regarding the response body.
What was one area of React you gained more clarity on during this assignment? Event handlers and callback functions; also React Router
Describe how you solved the problem of having lists of movies that look mostly the same but have different content Since there were two different components, one pulled from our local API while the other pulled from the external API. The search list results are displayed in one column, instead of having it all in flexbox. This differentiates it from the library which displays several columns of movies available in the library.
Describe how you handled rentals with React We send a POST request to our local API that includes the customer id, movie name, and due date. This went to an endpoint in the API that saves the record in a join table.
Describe a DOM event your application handled The DOM handled the onclick events by re-rendering and following the instructions in the different functions. One DOM event is to select a customer. On the list of customers, each customer has a "select" button. When one customer's event button is clicked, state is changed to store details about this customer and display them in the "selected" (for rental) display area.
Did you use any functional stateless components? What for? Our Home and Selected components are functional. The Home component renders an image and does not need to keep track of state. The Selected component renders the box that shows which movie and customer are selected and provides a checkout button to save the rental. This component does not need to keep track of state because that passed up to App via callback functions. (If we got to clearing the rental box and handling messages, we would have converted this a classical component.)
Did you use any container components? What for? We used App as our container component.
Do you have any recommendations on how we could improve this project for the next cohort? No three person groups. With the size of the project, we were bumping into each other. Hard to use our time effectively. Dealt more with organizing and people managing than actual code. Near the end we figured out that it was most effective to have the third person pair with someone.

I thought this was a good project that helped solidify several concepts. I feel more comfortable with connecting several pieces together.

dev-elle-up and others added 30 commits June 24, 2019 14:44
…hButtonHandler function in SearchTMDB component
selected, customer, and library components
Cleaned up small errors. Uncomment later if components are needed.
dev-elle-up and others added 21 commits June 27, 2019 16:21
Updated messages displayed to user on adding a duplicate movie.
…ementation of function to check out the selected movie to the selected customer. Getting an error - cannot read property 'handleSubmitRental' of undefined. Need to troubleshoot. Need to look more closely at what props are coming in from App to Selected, think the customer name is being passed and we need the id to send the post request. Side note - check props for selected movie and customer callback functions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants