Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ports- Amy M. & Steph #22

Open
wants to merge 71 commits into
base: master
Choose a base branch
from
Open

Conversation

smarchante1
Copy link

@smarchante1 smarchante1 commented Jun 28, 2019

Video Store Consumer

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Paste a link to the PR for your API Ada-C11/VideoStoreConsumer-API#14
For each person in your pair, describe something you learned from your partner during this project I learned from Amy that it is very helpful at times to create helper functions when expanding functionality of components i.d. filterMovies. I learned a lot of amazing CSS strategies from Steph, and also learned a lot from they way they approached partnership and sharing workload.
What was one area of React you gained more clarity on during this assignment? That arrow functions are an essential part of callback methods, and literally EVERYTHING WILL BREAK if you're not referencing the correct 'this.'
Describe how you solved the problem of having lists of movies that look mostly the same but have different content We created the component MovieCard that we rendered in both our Library and our Search components.
Describe how you handled rentals with React We made an API call to the Rails API to their checkout route, that created a new Rental object within the Rails database. We then displayed a success message and reset the state of "selected" items to null.
Describe a DOM event your application handled When you add a movie to the library from the external API, we refreshed the state within the API call in order to re-render the DOM so that the new movie would show up in our Library.
Did you use any functional stateless components? What for? We held our state in App and Search, and all other components were functional/presentational. Felt great.
Did you use any container components? What for? Yes, we used our App component as a container. It holds the data that we send to child components and also performs the methods for selecting and filtering that data.
Do you have any recommendations on how we could improve this project for the next cohort? Elaborate on the role of the intermediary rails Api before introducing the project. Give the students a deeper understanding of the expectations of communication between the front and back ends. Also please remove bugs from code please! :) <3

smarchante1 and others added 30 commits June 24, 2019 15:22
amyesh and others added 30 commits June 26, 2019 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants