Ports - Ari #4
Open
Ports - Ari #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d also made more efficient by removing the unused row_set and col_set and putting that logic into my first set of loops
joan8627
reviewed
May 6, 2019
There was a problem hiding this comment.
Good working solution! It is a great idea to mark the elements (setting it to 'x') for future use. Do you think there are alternative ways to mark the elements, such that when we look at an arbitrary element (e.g. matrix[i][j]), we know what to do (whether it becomes zero or stays the same) right away (without having to go down the row/column then come back to do what needed to be done)? Let me know if you need more explanation!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.