Ports - Ngoc #18
Open
Ports - Ngoc #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmcknett
reviewed
May 9, 2019
There was a problem hiding this comment.
Checklist
- Clean, working code
- Efficient code
- There's a solution that is
O(1)space complexity that involves a trick. See if you can figure it out, and feel free to ping me on Slack if you're curious!
- There's a solution that is
- A detailed explanation of time and space complexity (explains what n stands for, explains why it would be a specific complexity, etc.)
- All test cases for the assignment should be passing.
| # Space complexity: ? | ||
| #Approach 1: | ||
| # Time complexity: O(n^3) 3 nested loops | ||
| # Space complexity: O(n^2) n is the number of rows and columns in the matrix being cloned |
There was a problem hiding this comment.
This is true if the number of rows and columns are the same (i.e. the input matrix is a "square" matrix). However, if you allow the number of rows & columns to differ, you probably need to specify O(nm) and define n as the number of rows and m as the number of columns.
| # Time complexity: ? | ||
| # Space complexity: ? | ||
| #Approach 1: | ||
| # Time complexity: O(n^3) 3 nested loops |
| end | ||
|
|
||
| #Approach 2: | ||
| # Time complexity: O(n^2) 2 nested loops |
There was a problem hiding this comment.
Same comment as above (O(nm) instead of O(n^2)), but well done! This second implementation is a significant improvement over the O(n^3) implementation above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.