Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sockets - Nidhi #11

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Sockets - Nidhi #11

wants to merge 2 commits into from

Conversation

nidhiparixitpatel
Copy link

No description provided.

CheezItMan
CheezItMan reviewed May 12, 2019
View reviewed changes
Copy link

@CheezItMan CheezItMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This definitely works and has a very clever solution. There is another way to use the 1st row and column to store which row and column to zero out.

lib/matrix_convert_to_zero.rb

rows.times do |i|
columns.times do |j|
if sum_rows[i] + sum_columns[j] < max
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to say, this is really clever. Nicely done. It does require you to have two arrays, one for rows and the other for columns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CheezItMan CheezItMan CheezItMan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nidhiparixitpatel @CheezItMan