Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sockets - Grace #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions lib/heap_sort.rb
Original file line number Diff line number Diff line change
@@ -1,8 +1,22 @@


# This method uses a heap to sort an array.
# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: 0(n log n)
# Space Complexity: 0(1)
def heap_sort(list)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not working due to a bug in heap_down

raise NotImplementedError, "Method not implemented yet..."
end
heap = heapify(list)
until heap.empty?
element = heap.remove()
list.append(element)
end
return list
end

def heapify(list)
heap = MinHeap.new()
until list.empty?
element = list.pop()
heap.add(element)
end
return heap
end
46 changes: 33 additions & 13 deletions lib/min_heap.rb
Original file line number Diff line number Diff line change
Expand Up @@ -14,18 +14,23 @@ def initialize
end

# This method adds a HeapNode instance to the heap
# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: 0(log n)
# Space Complexity: 0(1)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since heap_down is recursive you have to consider the impact of the recursion on space complexity.

def add(key, value = key)
raise NotImplementedError, "Method not implemented yet..."
@store.append(HeapNode.new(key, value))
heap_up(@store.length - 1)
end

# This method removes and returns an element from the heap
# maintaining the heap structure
# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: 0(log n)
# Space Complexity: 0(1)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto for heap_up

def remove()
raise NotImplementedError, "Method not implemented yet..."
return if @store.empty?
swap(0, @store.length - 1)
removed_node = @store.pop
heap_down(0)
return removed_node.value
end


Expand All @@ -44,28 +49,43 @@ def to_s
end

# This method returns true if the heap is empty
# Time complexity: ?
# Space complexity: ?
# Time complexity: O(1)
# Space complexity: O(1)
def empty?
raise NotImplementedError, "Method not implemented yet..."
return @store.empty?
end

private

# This helper method takes an index and
# moves it up the heap, if it is less than it's parent node.
# It could be **very** helpful for the add method.
# Time complexity: ?
# Space complexity: ?
# Time complexity: O(log n)
# Space complexity: O(1)
def heap_up(index)

return if index == 0
until index == 0 || @store[index].key >= @store[((index - 1) / 2)].key
parent_index = (index - 1) / 2
swap(index, parent_index) if @store[parent_index].key > @store[index].key
index = parent_index
end
end

# This helper method takes an index and
# moves it up the heap if it's smaller
# than it's parent node.
def heap_down(index)
raise NotImplementedError, "Method not implemented yet..."
left = (2 * index) + 1
right = (2 * index) + 2
if !@store[left] && !@store[right]
return
elsif !@store[right]
min = left
else
min = [left, right].min_by {|x| @store[x].key}
end
swap(index, min)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't quite working because you're not checking to see if the element at index is greater than the element at min.

 if @store[index] > @store[min]
    swap(index, min)
    heap_down(min)
end

heap_down(min)
end

# If you want a swap method... you're welcome
Expand Down