Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ports - Shamira #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Ports - Shamira #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions lib/fibonacci.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,19 @@
# ....
# e.g. 6th fibonacci number is 8

# Time complexity: ?
# Space complexity: ?
# Time complexity: O(n) with n being the input.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually your solution is O(2^n) in time complexity. We'll talk about this in the recursion lesson.

# Space complexity: O(1)- constant because it take the same amount of space regardless of the input.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space complexity is actually dependent on the number of recursive calls. Each time you make a call to fibonacci it has to save the previous call in the stack.

def fibonacci(n)
raise NotImplementedError
if n == nil || n < 0
raise ArgumentError, "n cannot be nill or negaitve"
end

if n == 1 || n == 2
result = 1
elsif n == 0
result = 0
else
result = fibonacci(n - 1) + fibonacci(n - 2)
end
return result
end