Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ports - sav #31

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

ports - sav #31

wants to merge 11 commits into from

Conversation

qqdipps
Copy link

@qqdipps qqdipps commented Jun 21, 2019

Exquisite React

Congratulations! You're submitting your assignment.

Comprehension Questions

Feature Feedback
How did this project differ from in-class examples? I think that all the concepts have been reviewed in class to some degree. I guess I would say that there is more view hiding and displaying with conditionals in JSX then we've done before.
How was this project similar to in-class examples? Everything.
If you had time to refactor one part of this project, what would you do to make it better? I call validations() method twice in PlayerSubmissionForm.js inside different methods with the purpose of creating a constant. Probably better to create a constant with a greater scope that can be ref inside methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant