Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ports - Elle #29

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Ports - Elle #29

wants to merge 11 commits into from

Conversation

dev-elle-up
Copy link

@dev-elle-up dev-elle-up commented Jun 21, 2019 •
edited
Loading

Exquisite React

Congratulations! You're submitting your assignment.

Comprehension Questions

Feature Feedback
How did this project differ from in-class examples? The biggest difference was implementing conditionals to display certain components at certain times.
How was this project similar to in-class examples? Passing props, using state to keep track of things that changed, using event handlers to call callback functions which were called in a parent component, keeping functionality and display separate, using external (not inline) styling.
If you had time to refactor one part of this project, what would you do to make it better? I would implement the spread operator.

dev-elle-up added 11 commits June 19, 2019 19:33
@dev-elle-up
Implemented the form. Currently not saving the full string to newPoem…
1cfbee3 
…Line.
@dev-elle-up
Form takes inputs, updates state with most recent line, and renders t…
36a6590 
…he RecentSubmission component.
@dev-elle-up
The RecentSubmission component does not render if lastPoemLine is an …
5c2e651 
…empty string. Component is hidden until Player 1 submits an entry.
@dev-elle-up
Added counter for player number.Increments each time a new line is su…
9c0577a 
…bmitted.
@dev-elle-up
When poem line is submitted, it gets added to the poemLines array in …
093cc23 
…Game's state.
@dev-elle-up
Added conditional to check if line is empty before adding to poem lin…
b16a453 
…es array. This prevents the initial state from being added. Also played with two ways to update the submission form's state and observed asyncronous processing... FUN
@dev-elle-up
Fixed formatting of lines so they display on separate lines. Also con…
3370689 
…firmed lines are being saved to the array and only the last line is shown to the next player. All is in working order.
@dev-elle-up
All poem lines displayed on button click.
a5bf86d
@dev-elle-up
Implemented conditional to hide input form when button is clicked and…
43d8ad4 
… poemFinished state is set to true.
@dev-elle-up
Added pink color to field that hasn't had an entry yet.
50d6b6d
@dev-elle-up
Cleaned up comments. Need to implement a conditional and regex to che…
60fd7aa 
…ck if field is empty.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dev-elle-up