Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ports - Mina #23

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Ports - Mina #23

wants to merge 6 commits into from

Conversation

minams
Copy link

@minams minams commented Jun 20, 2019

Exquisite React

Congratulations! You're submitting your assignment.

Comprehension Questions

Feature Feedback
How did this project differ from in-class examples? Nesting the conditional statements in JSX was different.
How was this project similar to in-class examples? The callbacks, form, understanding how state and props are used to exchange data between components.
If you had time to refactor one part of this project, what would you do to make it better? I would try to find a better way of when to make certain aspects of the page disappear once the Reveal button is pushed. I'd also like to refactor my PlayerSubmissionForm.js file. There are a lot of repeating code and the way that I wasn't super happy with returning the hardcoded string in my addLineCallback function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant