KS #21

goblineer · 2019-10-18T00:47:11Z

No description provided.

CheezItMan

Nice work! Small issues with newman conway, but this is a good submission.

CheezItMan · 2019-10-18T19:32:30Z

lib/newman_conway.rb

+    output += "#{m[i]}"
+  end


This could probably be replaced with:

Suggested change

(2..num).each do |i|

output += "#{m[i]}"

end

return m.join(" ")

CheezItMan · 2019-10-18T19:33:40Z

lib/max_subarray.rb

+    (1...nums.length).each do |i|
+        max_now = nums[i] > max_now + nums[i] ? nums[i] : max_now + nums[i]
+        max = max_now if max_now > max
+    end


Very concise

goblineer added 4 commits October 17, 2019 17:26

newman conway method

f7200d6

Update newman_conway.rb

6614097

max_subarray dynamic programming

fdacf03

Update max_subarray.rb

f2538cc

CheezItMan reviewed Oct 18, 2019

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

KS #21

KS #21

goblineer commented Oct 18, 2019

CheezItMan left a comment

CheezItMan Oct 18, 2019

CheezItMan Oct 18, 2019

-  (2..num).each do |i|
-    output += "#{m[i]}"
-  end
+  return m.join(" ")

KS #21

Are you sure you want to change the base?

KS #21

Conversation

goblineer commented Oct 18, 2019

CheezItMan left a comment

Choose a reason for hiding this comment

CheezItMan Oct 18, 2019

Choose a reason for hiding this comment

CheezItMan Oct 18, 2019

Choose a reason for hiding this comment