Sockets - Karla #16
Open
Sockets - Karla #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jadevance
reviewed
Apr 19, 2019
| @@ -1,6 +1,28 @@ | |||
| # Returns a new array to that contains elements in the intersection of the two input arrays | |||
| # Time complexity: ? | |||
| # Space complexity: ? | |||
| # Time complexity: O(n + m) where n and m are the lengths of the two array inputs | |||
There was a problem hiding this comment.
Will both arrays always be equal in length?
| elsif array1.length < array2.length | ||
| larger = array2 | ||
| smaller = array1 | ||
| elsif array1.length >= array2.length |
There was a problem hiding this comment.
I notice you used >= but not <= on line 8 for comparison. What's your thinking behind this choice?
|
|
||
| hash_table = {} | ||
| smaller.each do |num| | ||
| hash_table[num] = 1 |
There was a problem hiding this comment.
What happens if two keys are the same?
| combined = [] | ||
| larger.each do |num| | ||
| if hash_table.include? num | ||
| combined << num |
There was a problem hiding this comment.
I'm not sure if anything is being combined here. Perhaps matches might be a better variable name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.