Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sockets - Kate N #41

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions lib/array_equals.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,42 @@
# and the same integer values in the same exact order
def array_equals(array1, array2)
raise NotImplementedError

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to remove the raise here, otherwise it will throw an exception.

if array1 == [] && array2 == [] || array1 == nil && array2 == nil
return true
elsif array1 == nil || array2 == nil || array1.length != array2.length
return false
else
array1.length.times do |i|
if array2[i] != array1[i]
return false
end
end
return true
end
end

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is clear, concise and easy to read. Good work!

# NOTES WHILE WORKING THROUGH

# if
# array1.length =! array2.length
# returns false
# break

# index = 0
# while index < array.length
# element = array[index]
# #do operation
# index += 1
# end

# array_equals

# false?
# arrays are not exactly the same
# element values different
# elements not in the same order

# true?
# arrays have some # of elements
# element values are the same
# order is the same