-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sockets - Carla #40
base: master
Are you sure you want to change the base?
Sockets - Carla #40
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,26 @@ | ||
# Determines if the two input arrays have the same count of elements | ||
# and the same integer values in the same exact order | ||
def array_equals(array1, array2) | ||
raise NotImplementedError | ||
if (array1 == nil && array2 == nil) || (array1 == [] && array2 == []) | ||
return true | ||
elsif array1 == nil || array2 == nil | ||
return false | ||
end | ||
|
||
if array1.length == array2.length | ||
loop_count = array1.length | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Tiny style nit: is this extra variable necessary? |
||
loop_count.times do |i| | ||
if array1[i] != array2[i] | ||
return false | ||
else | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Style nit: do we need this ( |
||
i += 1 | ||
if i == loop_count | ||
return true | ||
end | ||
end | ||
end | ||
else | ||
return false | ||
end | ||
|
||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style nit: using a "guarding if" that checks if
array1.length
does not equalarray2.length
is probably more readable here. (If nothing else, more programmers are used to that pattern - so it's easier for your coworkers to recognize.)