Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sockets - Carla #40

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion lib/array_equals.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,26 @@
# Determines if the two input arrays have the same count of elements
# and the same integer values in the same exact order
def array_equals(array1, array2)
raise NotImplementedError
if (array1 == nil && array2 == nil) || (array1 == [] && array2 == [])
return true
elsif array1 == nil || array2 == nil
return false
end

if array1.length == array2.length
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style nit: using a "guarding if" that checks if array1.length does not equal array2.length is probably more readable here. (If nothing else, more programmers are used to that pattern - so it's easier for your coworkers to recognize.)

loop_count = array1.length
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny style nit: is this extra variable necessary?

loop_count.times do |i|
if array1[i] != array2[i]
return false
else
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style nit: do we need this else block? I have a feeling we can delete it, if we put a return true statement after it.

(returning exits the function - so any code after an executed return statement won't run.)

i += 1
if i == loop_count
return true
end
end
end
else
return false
end

end