Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sockets - Grace #36

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Sockets - Grace #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added .DS_Store
View file
Open in desktop
Binary file not shown.
13 changes: 10 additions & 3 deletions lib/array_equals.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# Determines if the two input arrays have the same count of elements
# and the same integer values in the same exact order

def array_equals(array1, array2)
raise NotImplementedError
return true if array1 == nil and array2 == nil
return false if !array1 or !array2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two lines correctly handle all the cases where one array is nil, but there are two readability/maintainability problems.

First, you use (array1 == nil) on one line and then (!array1) on the next line to mean the same thing. Pick one and be consistent, at least within the method. (!array1) is fine for a small codebase where there are no team members who object to terse code. So, basically, not a real-world team. (array1 == nil) is much clearer.

Second, these two lines look like two independent checks for error conditions, but in reality the second line depends on the first. It's the cleanest way to write the code, but makes it easy for a future maintenance programmer to muck it up. Maybe add a comment.

return false if array1.length != array2.length

array1.length.times do |index|
return false if array1[index] != array2[index]
end

return true
end