Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sockets - Erica #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Sockets - Erica #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion lib/array_equals.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,26 @@
# Determines if the two input arrays have the same count of elements
# and the same integer values in the same exact order
def array_equals(array1, array2)
raise NotImplementedError
if array1 == nil || array2 == nil
if array1 == nil && array2 == nil
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole block takes the form of:

if (condition) return true else return false end

Simplify to: return (condition)

The latter is more readable and easier to type.

return true
else
return false
end
elsif array1.length == array2.length
if array1.length == 0
return true
else
i = 0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary initialization.

array1.length.times do |i|
if array1[i] != array2[i]
return false
end
i += 1
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The array.length.times method replaces the value of i with whatever comes next, so this statement is redundant and has no real effect. Remove.

end
return true
end
else
return false
end
end
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General comment: blank lines are your friend. Add some whitespace between logical blocks of code.