Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ports - Heather #32

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Ports - Heather #32

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5bbc8d2
compares two arrays
piffer59 Feb 28, 2019
8b7c628
Fixed array_equals conditionals
piffer59 Mar 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion lib/array_equals.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,24 @@
# Determines if the two input arrays have the same count of elements
# and the same integer values in the same exact order
def array_equals(array1, array2)
raise NotImplementedError
if array1 == nil && array2 == nil
return true
elsif array1 == nil || array2 == nil
return false
elsif array1.length != array2.length
return false
elsif array1.length == array2.length
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to check the lengths of the array here. If your fn gets to this line you already know the arrays have the same length.

element_count = 0
array1.length.times do |x|
if array1[x] == array2[x]
element_count += 1
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping track of element_count is extra work. If the elements of the arrays (at the same index) are not equal, you should return false right away.

else
return false
end
end
end

if array1.length == element_count
return true
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point, verifying that element_count equals the length of the first array is an extra check. This conditional (line 21) will always be true. So you can get rid of the check and just return true.

end
end