Ports_AmyM_Myriam

[MyriamWD]

Adagrams

Congratulations! You're submitting your assignment.

Comprehension Questions

Feature	Feedback
What are the components that make up a method?	Method signature, optional arguments, block of code, and implicit or preferably explicit return.
What are the advantages of using git when collaboratively working on one code base?	That we both have access to code.
What kind of relationship did you and your pair have with the unit tests?	At the beginning complete confusion at the end better understanding on when to use them and why.
Does your code use any methods from the Enumerable mixin? If so, where and why was it helpful?	No, we decided we'll try to use enumerables when refactoring but we never got to refactoring.
What was one method you and your pair used to debug code?	Looking at StackTrace and puts(ing).
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share?	We realized that we didn't have clear expectations at some point during the week and we talked it through.

[CheezItMan]

Adagrams

What We're Looking For

Feature	Feedback
General
Answered comprehension questions	Check, I'm glad you got the chance to talk through expectations
Both teammates contributed to the codebase	I assume so
Small commits with meaningful commit messages	You only have 3 commits and they are rather large. Also don't use waves in your commit messages, instead describe the functionality you've added. If you can't sum it up in one commit line, that's an indication that your commit wasn't granular enough.
Code Requirements
draw_letters method	Check
Uses appropriate data structure to store the letter distribution	Check
All tests for draw_letters pass	Check
uses_available_letters? method	Check
All tests for uses_available_letters? pass	Check
score_word method	Check, but it doesn't handle lower case letters.
Uses appropriate data structure to store the letter scores	Your code was very repetitive, it could be simplified by setting up a data structure to handle letter scores.
All tests for score_word pass	Mostly didn't handle lower case letters.
highest_score_from method	Check
Appropriately handles edge cases for tie-breaking logic	MISSING no handling of tied scores.
All tests for highest_score_from pass	No handling of ties
Overall	You hit most of the learning goals for the project. See my inline notes for suggestions on what to adjust. Let me know if you have any questions.