ports- cloudy and mina #2
Conversation
AdagramsWhat We're Looking For
Good work on this project, Cloudy and Mina! You did a great job on getting working implementation in a readable, logical, clean way. I really liked some of your solutions; especially the ones with Enumerable methods, and with clear conditionals like the I left a few comments, one mostly about one not-very-concise piece of code. That being said, good work on this overall! |
| puts "Please make the best work with the letters you were dealt." | ||
| new_word = gets.chomp.to_s.upcase | ||
|
|
||
| uses_available_letters?(new_word, drawn_letters) |
There was a problem hiding this comment.
In the future, feel free to delete any unused files before submitting!
| my_letters = [] | ||
| random_letter = pool_of_letters.shuffle | ||
| 10.times do | ||
| my_letters.push(random_letter[-1]) |
There was a problem hiding this comment.
Just to make it clear what's going on: You have the pool_of_letters array, and then shuffle it, and put the shuffled array into a variable called random_letter. Then, you do this ten times: you push into your array my_letters the value of the item that is last in the random_letter array (the thing at index of -1 is the last item). And then you call random_letter.pop, which removes the last item from the array. This strategy is great! It just feels a little unreadable. I think that the name random_letter feels inaccurate, since it doesn't represent one single random letter, but the array of the shuffled pool of letters. Also, instead of maybe using the syntax random_letter[-1], even though it's very short and concise, it might be more readable to use random_letter.last.
There are also interesting things that .pop does that you'll learn about in the future :)
| end | ||
|
|
||
| def uses_available_letters?(input, letters_in_hand) | ||
| word = input.upcase.split(//) |
There was a problem hiding this comment.
I just remembered that I was supposed to get in touch with Cloudy so that her VS Code indented with 2 spaces instead of 4 :)
| my_score += 8 | ||
| end | ||
|
|
||
| return my_score |
There was a problem hiding this comment.
Nice method implementation, and nice use of Enumerable methods!
| elsif word.length < winning_hash[:word].length && winning_hash[:word].length != 10 | ||
| winning_hash[:word] = word | ||
| end | ||
| end |
There was a problem hiding this comment.
This complex logic is really readable-- good work on this wave!
Adagrams
Congratulations! You're submitting your assignment.
Comprehension Questions
Enumerablemixin? If so, where and why was it helpful?