Sockets - Shirley

[shirley1chu]

Task List

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Describe in your own words what the Model is doing in Rails	It contains the information, and likely organization and manipulation of the information that is needed for the program.
Describe in your own words what the Controller is doing in Rails	It interprets the request from the browser and uses actions to get the needed information from the models. It them sends this information back to the browser.
Describe in your own words what the View is doing in Rails	It displays the information sent by the controller to the user in the browser
Describe an edge-case controller test you wrote	An attempt to destroy a non-existent task, the program redirects to the homepage.
What is the purpose of using strong params? (i.e. the params method in the controller)	To "wrap" the parameters and reduce risk of errors when extracting attributes from the params hash.
How are Rails migrations related to Rails models?	Migrations update changes in the data to the database, which then affect the attributes of the models (what attributes the model has, and the data type of these attributes)
Describe one area of Rails that are still unclear on	There was a task.scss file for the Task controller. Was I supposed to do styling for all the pages on that one file, or make separate files for each specific webpage?

[CheezItMan]

Task List

What We're Looking For

Feature	Feedback
Baseline
Appropriate Git Usage with no extraneous files checked in	You should have more commits, but the commit messages are good.
Answered comprehension questions	Check, models interface with the database. A view takes data from the controller and renders html to the browser. Part of the purpose of strong params is security. It prevents unanticipated fields being passed in. Migrations change the structure of the database, not the data exactly. Put styles that impact all the pages in the site in application.scss. In general that's where most of your styles will go.
Successfully handles: Index, Show	Check
Index & Show tests pass	Check
Successfully handles: New, Create	Check
New & Create tests pass	Check
Successfully handles: Edit, Update	Check
Tests for Edit & Update test valid & invalid task ids	Check
Successfully handles: Destroy, Task Complete	Check, interesting way to do it with form_with, you can also do it with link_to or button_to.
Tests for Destroy & Task Complete include tests for valid and invalid task ids	Check
Routes follow RESTful conventions	Check
Uses named routes (like _path)	Check
Overall	Great work, you hit all the learning goals for this project. See my inline notes and let me know any questions you have.

[CheezItMan]

Great way to DRY up your code!

[CheezItMan]

You could also do this with:

<%= button_to "#{task.completion_date ? 'Unmark Complete' : 'Mark Complete'}", complete_task_path(task), method: patch, class: "button" %>

[CheezItMan]

theoretically this could be a valid ID. Instead I suggest using -1 or "invalid id" as the ID for this test.

[CheezItMan]

similar to the above

[CheezItMan]

ditto to the above

[CheezItMan]

Nice work on this!