Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrote possible_bipartition method. All tests passing. #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Wrote possible_bipartition method. All tests passing. #7

wants to merge 1 commit into from

Conversation

dev-elle-up
Copy link

No description provided.

CheezItMan
CheezItMan reviewed Oct 20, 2019
View reviewed changes
Copy link

@CheezItMan CheezItMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This absolutely a good BFS solution here. Nice work!

lib/possible_bipartition.rb
nodes_hash = {}

dislikes.each do |dislike|
q.unshift(i) if !nodes_hash[i]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would use << or push instead of unshift. Just because you put things on the rear of a queue. It's functionally equivalent in this case, because the queue is empty, but it's not treating q like a queue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CheezItMan CheezItMan CheezItMan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dev-elle-up @CheezItMan