Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amanda, Cassie, Hannah - VideoStore #6

Open
wants to merge 94 commits into
base: master
Choose a base branch
from

Conversation

hertweckhr1
Copy link

@hertweckhr1 hertweckhr1 commented Dec 20, 2018

Video Store Consumer

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Paste a link to the PR for your API Ada-C10/VideoStoreConsumer-API#6
For each person in your pair, describe something you learned from your partner during this project Hannah - I learned about grabbing info from external API from Amanda and I learned a bunch of awesome debugging and fixing all our problems from Cassie. Cassy - I learned some awesome new CSS techniques from Hannah and learned some cool component structuring from Amanda. Amanda - I learned about debugging strategies and how to make sure information is getting properly passed from Cassy and I learned about how to format and make my code usable on the front end from Hannah.
What was one area of React you gained more clarity on during this assignment? We gained more clarity and practice how to link react axios requests with Rails Backend API. We also learned how to pass props and callbacks via React Router.
Describe how you solved the problem of having lists of movies that look mostly the same but have different content Depending on the page we showed, when mapping over the information, we called it depending on how it looked in JSON.
Describe how you handled rentals with React We looked at the checkout in the videostore API to get the information needed to be passed in the post request. We then created a axios post request with customer_id, movie_id, setting due_date to be 7 days from now, and giving the correct URL. If the user forgot to enter a movie or a customer we provided appropriate alert messages.
Describe a DOM event your application handled In the SearchBar we completed onSubmit which allows the user to click or press enter to search through the movies in the API based on the query. The onSubmit then called the onSubmit function completing the action.
Did you use any functional stateless components? What for? We used stateless components for all but videostore, searchResult and searchbar. The reason we did this is because we were instructed to keep components stateless unless needed.
Did you use any container components? What for? We used VideoStore as a container component so we could easily reuse or transfer this component from App.js if needed. We used Search as a container component for SearchList and SearchResults.
Do you have any recommendations on how we could improve this project for the next cohort? Include the idea of setTimer in suggestions to make flash(alert/error) messages go away.

amandaungco and others added 30 commits December 17, 2018 15:27
hertweckhr1 and others added 30 commits December 19, 2018 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants