Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goeun + Katricia | Edges | Video Store Consumer #18

Open
wants to merge 101 commits into
base: master
Choose a base branch
from

Conversation

krsmith7
Copy link

@krsmith7 krsmith7 commented Dec 22, 2018

Video Store Consumer

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Paste a link to the PR for your API
For each person in your pair, describe something you learned from your partner during this project Goeun: Big picture organization structure of code and specifically what components should be. Katricia: More concise use of classical components, state and props.
What was one area of React you gained more clarity on during this assignment? Reacstrap, React Router
Describe how you solved the problem of having lists of movies that look mostly the same but have different content Naming components with distinct names
Describe how you handled rentals with React We have on an onClick that sends to a function that contains an axios post request.
Describe a DOM event your application handled Clicking buttons for actions like Add to Library and Select Rental
Did you use any functional stateless components? What for? We used stateless components for components that only needed to render data from other components and not pass or change data.
Did you use any container components? What for? We used containers for Nav items (Navbar) and Movie items (Library).
Do you have any recommendations on how we could improve this project for the next cohort?

goeunpark and others added 30 commits December 17, 2018 14:20
krsmith7 and others added 30 commits December 20, 2018 23:46
… movie id. Remove Library selectedMovie state
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants