Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hayden - Edges (C10) - Palindrome Check #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion lib/palindrome_check.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,28 @@
# A method to check if the input string is a palindrome.
# Return true if the string is a palindrome. Return false otherwise.
def palindrome_check(my_phrase)
raise NotImplementedError
if my_phrase == nil
return false
end
i = 0
j = my_phrase.length - 1
while i < j
if my_phrase[i] == " " || my_phrase[j] == " "
until my_phrase[i] != " "

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the two nested inner loops, continue to check and confirm that i is less than j before comparing the character at the index i (or j) with a white space.

i += 1
end
until my_phrase[j] != " "
j -= 1
end
elsif my_phrase[i] != my_phrase[j]
return false
end
i += 1
j -= 1
end
return true
end


# time complexity: O(n) because it must iterate through each element in the array

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always explain what n stands for while explaining your time and space complexity. In this case, it would be the number of characters in the input string or the size of the input string.

# space complexity: O(1) because it does not require any additional memory space besides the iteration variables