Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shelan-Inspiration Board #46

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Shelan-Inspiration Board #46

wants to merge 4 commits into from

Conversation

sheland
Copy link

@sheland sheland commented Dec 25, 2018

Inspiration Board

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Explain the steps in creating a new Card from the form. The add card callback gets the data from the form, which gets passed through as props which then passes the form data to the function.
How did you learn how to use the API? I followed the class examples and used Postman to do get requests using the API documentation.
What function did you use to place the GET request from the API to get the list of cards? Why use that function? I used componentdDidMount.
Explain the purpose of a Snapshot test. It allows us to detect when components are changed so we can ensure that components are rendering properly
What purpose does Enzyme serve in testing a React app? It allows us to do shallow and deep tests.

@sheland sheland changed the title Inspiration Board-Shelan Shelan-Inspiration Board Dec 25, 2018
@CheezItMan
Copy link

Inspiration Board

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene
Comprehension questions
General
Card Component renders the data provided as props
Board Component takes a URL and renders the list of Cards and passes in callback functions
NewCardform Component is a controlled form and uses a callback function to return entered data to the parent component
API
GET request made in componentDidMount Check
DELETE request made in callback function Check
POST request made in callback function passed to NewCardForm component. Check
Snapshot testing Check
Styling Looks good
Overall One note, you put an inspiration board app inside the inspiration board folder, which confused me at first. You also don't have error handling with your API requests. Otherwise well done!

@@ -0,0 +1,23 @@
# See https://help.github.com/articles/ignoring-files/ for more about ignoring files.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note the paths of these files, you put an inspiration board project inside the inspiration board project.

};
console.log(apiPayload)
const {url,boardName} = this.props;
axios.post(url + boardName +'/cards', apiPayload)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're not doing any error handling with your API requests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants