Katricia - Edges - Calculator #47
Conversation
CalculatorWhat We're Looking For
Great job overall! This program works well, and I appreciate the way you've used whitespace and methods to break up your code. There are a few places where things could be cleaned up that I've tried to call out inline below, but in general I am quite pleased with this submission. Keep up the hard work! |
| print "Second number: " | ||
| second_num = gets.chomp | ||
| until second_num =~ /\d/ | ||
| puts number_reprompt |
There was a problem hiding this comment.
You've written almost exactly the same code here twice, to get the first number and the second number. Could you DRY that up by putting this logic in a method?
| when "divide", "/" | ||
| if second_num != 0 | ||
| total = divide(first_num, second_num) | ||
| # If second number is zero, do not invoke method. Assign zero message to total. |
There was a problem hiding this comment.
Could you put this division-specific error handling code in the division method?
| # Case statement to link input to defined operator method and invoke method to get total | ||
| case operator | ||
| when "add", "+" | ||
| total = add(first_num, second_num) |
There was a problem hiding this comment.
This code isn't repeated, but I think it would still increase readability to wrap this case/when section in a method. That would clearly delineate where it starts and ends, and make it explicit what data it needs to work. The method signature might be something like perform_calculation(operator, first_num, second_num).
| # Reprompt user until input is one of operators in operator array | ||
| until operator_options.include? input | ||
| puts "Please input the name or symbol of a valid operator." | ||
| input = gets.chomp |
Calculator
Congratulations! You're submitting your assignment.
Comprehension Questions