Melissa - Calculator - Edges #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CalculatorWhat We're Looking For
Good job overall! You've done a good job of organizing and breaking up your code using methods and whitespace. There are a couple of places where things could be cleaned up, which I've tried to call out inline below, but in general I am quite happy with this submission. Keep up the hard work! |
|
|
||
| if user_input == "add" || user_input == "+" | ||
| puts "Give me 2 #'s': " | ||
| print "#1: " |
| def get_user_num | ||
| user_num = gets.chomp | ||
| until user_num =~ /\A[-+]?[0-9]*\.?[0-9]+\Z/ | ||
| print "Not a valid number. Try again: " |
There was a problem hiding this comment.
Good use of methods here to break this code up and make it readable.
| elsif user_input == "subtract" || user_input == "-" | ||
| puts "Give me 2 #'s': " | ||
| print "#1: " | ||
| num_1 = get_user_num() |
There was a problem hiding this comment.
You touched on this in your answers to the comprehension questions, but you've got the same code copy-pasted several times here. You could use a method to DRY this up, but the better thing to do might be to move the work to before the if.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calculator
Congratulations! You're submitting your assignment.
Comprehension Questions