Create calculator.rb #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CalculatorWhat We're Looking For
|
CheezItMan
reviewed
Aug 9, 2018
| end | ||
|
|
||
| # methods used | ||
| def add(num1, num2) |
There was a problem hiding this comment.
This is more of a style thing. It's a little odd putting the method definitions here in the middle of the program flow. I suggest moving method definitions to the top of the file.
| operation = gets.chop.downcase | ||
| end | ||
|
|
||
| # collects two numbers for calculation |
There was a problem hiding this comment.
Do you think this method block could be turned into a reusable method?
| puts "#{value_1} * #{value_2} = #{solution}" | ||
|
|
||
| elsif operation == "/" || operation == "solution" | ||
| if value_1 == 0 || value_2 == 0 |
There was a problem hiding this comment.
Dividing something by zero is not zero. It's undefined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calculator
Congratulations! You're submitting your assignment.
Comprehension Questions