Solar_System

[jazziesf]

Solar System

Congratulations! You're submitting your assignment.

Comprehension Questions

Question	Answer
When does the initialize method run? What does it do?	Creates an instance of the objects.
Why do you imagine we made our instance variables readable but not writable?
We would make them writable if we wanted the user to modify the information. In this case we do not.
How would your program be different if each planet was stored as a Hash instead of an instance of a class?	You would have to interate through the hash each time to look for the information rather than call the method. Your code would be very repetitive.
How would your program be different if your SolarSystem class used a Hash instead of an Array to store the list of planets?	The information would be at random rather than an ordered list
The Single Responsibility Principle (SRP) says that each class should be responsible for exactly one thing. Do your classes follow SRP? What responsibilities do they have?	I would say all but one follows the SRP. I should have created a class for user input.
How did you organize your require statements? Which files needed requires, and which did not? What is the pattern?	Only our main program required data from the Solar system and Planets. Planet nor Solar System needed data from each other therefore they did not require file.

[CheezItMan]

Solar System

What We're Looking For

Feature	Feedback
Baseline
Whitespace (indentation, vertical space, etc)	Good
Variable names	Check
Git hygiene	Decent number of commits, and good commit messages overall.
Planet
initialize method stores parameters as instance variables with appropriate reader methods	Check
summary method returns a string	Check
SolarSystem
initialize creates an empty list of planets	Check
add_planet takes an instance of Planet and adds it to the list	Check
list_planets returns a string	Check
find_planet_by_name returns the correct instance of Planet	Check
CLI
Can list planets and quit	Check
Can show planet details	Check
Can add a planet	Check
Complex functionality is broken out into separate methods	Nope
Overall	Nice job, you hit all the learning goals for this project. Great work! I did leave some inline notes in your code. Let me know if you have any questions.

[CheezItMan]

This method is just begging to be broken up into smaller methods 🙏

[CheezItMan]

This method should not use puts. Instead just return nil

[CheezItMan]

You could also do this with:

return @planets.find do |planet|
  planet.name.downcase == found_planet.downcase
end