Amber Lynn - Edges - Solar-System

[griffifam]

Solar System

Congratulations! You're submitting your assignment.

Comprehension Questions

Question	Answer
When does the initialize method run? What does it do?	When a method is called
Why do you imagine we made our instance variables readable but not writable?	Because we don't plan to change them at any point and don't want anyone else to either.
How would your program be different if each planet was stored as a Hash instead of an instance of a class?	They would have less functionality
How would your program be different if your SolarSystem class used a Hash instead of an Array to store the list of planets?	The data inside would not behave the way I'd want.
The Single Responsibility Principle (SRP) says that each class should be responsible for exactly one thing. Do your classes follow SRP? What responsibilities do they have?	One class is responsible for creating planets. The other is responsible for taking in and storing planets in an array.
How did you organize your require statements? Which files needed requires, and which did not? What is the pattern?	planet.rb and solar system.rb that hold my classes. Classes should have their own file and we can require them in our main file to bring it all together.

[droberts-sea]

Solar System

What We're Looking For

Feature	Feedback
Baseline
Whitespace (indentation, vertical space, etc)	yes
Variable names	yes
Git hygiene	yes - good work
Planet
initialize method stores parameters as instance variables with appropriate reader methods	yes
summary method returns a string	yes
SolarSystem
initialize creates an empty list of planets	yes
add_planet takes an instance of Planet and adds it to the list	yes
list_planets returns a string	yes
find_planet_by_name returns the correct instance of Planet	not quite - see inline
CLI
Can list planets and quit	yes
Can show planet details	yes
Can add a planet	yes
Complex functionality is broken out into separate methods	yes
Overall	Good work overall! This code is well-organized and easy to read, and does a good job of solving the problem at hand. I've left a few inline comments for you to review, but it's clear the learning goals of the assignment were met. Keep up the hard work!

[droberts-sea]

This work is complex enough it would probably make sense to put it in a separate method.

[droberts-sea]

This definitely solves the problem, but we could clean this code up a little by using an enumerable:

def find_planet_by_name(planet_name)
  planet_name = planet_name.downcase
  return @planets.find { |planet| planet.name.downcase == planet_name }
end

[droberts-sea]

Instead of returning the summary here, you should return the planet itself. Then whoever calls this method can do what they want with it. That might be printing the summary, comparing it with another planet, etc.

[droberts-sea]

Also, I think this will not quite work if the planet is not found.