Danielle Metzner - Solar System

[danimetz]

Solar System

Congratulations! You're submitting your assignment.

Comprehension Questions

Question	Answer
When does the initialize method run? What does it do?	The initialize method runs at the beginning of each class (planets & SolarSystem) It determines what is needed to create the class.
Why do you imagine we made our instance variables readable but not writable?	We don't want the user to be able to access the planet once it's initially created to change any of the characteristics of the planets.
How would your program be different if each planet was stored as a Hash instead of an instance of a class?	Instead of instance variables we would have the "name", "color", etc. as keys and the details as the values.
How would your program be different if your SolarSystem class used a Hash instead of an Array to store the list of planets?	You would need to know the planet name to access the info.
The Single Responsibility Principle (SRP) says that each class should be responsible for exactly one thing. Do your classes follow SRP? What responsibilities do they have?	Yes, the planet class only creates the planets. The solar system accesses the planets that are stored and retrieves their information
How did you organize your require statements? Which files needed requires, and which did not? What is the pattern?	Only main.rb and spec required the different class files. I always organized the requires at the top of the file, with the more specific one first (planets).

[CheezItMan]

Solar System

What We're Looking For

Feature	Feedback
Baseline
Whitespace (indentation, vertical space, etc)	Well done
Variable names	Nice
Git hygiene	Good number of commits and good commit messages
Planet
initialize method stores parameters as instance variables with appropriate reader methods	Check
summary method returns a string	Check
SolarSystem
initialize creates an empty list of planets	Check
add_planet takes an instance of Planet and adds it to the list	Check
list_planets returns a string	Check
find_planet_by_name returns the correct instance of Planet	Nice
CLI
Can list planets and quit	Check
Can show planet details	Check
Can add a planet	Check
Complex functionality is broken out into separate methods	Nope!
Overall	Well done, you hit all the learning goals for the project. Excellent work. I did leave a few minor comments in your code, but you did very well!

[CheezItMan]

nice 🥇

[CheezItMan]

It's convention to put the attr_reader and attr_accessor etc above initialize and below the class name

[CheezItMan]

This method is just crying to be broken into smaller methods!

[CheezItMan]

You could also use .find instead of .select