Laura_solar_system

[lauracodecreations]

Solar System

Congratulations! You're submitting your assignment.

Comprehension Questions

Question	Answer
When does the initialize method run? What does it do?	it defines the instance variable that we are going to use throughout the program.
Why do you imagine we made our instance variables readable but not writable?	to allow the user to read the value in these variables, but not overwrite them. It gives us control over how we want the program to run because the user cannot write to them.
How would your program be different if each planet was stored as a Hash instead of an instance of a class?	I will not be able to apply methods to the planet like planet.name, so the solar system class methodology will have to change to expect and iterate over a hash to find the information that it needs like list planet or find planet by name
How would your program be different if your SolarSystem class used a Hash instead of an Array to store the list of planets?	it will not allow duplicate planets because each key has to be unique
The Single Responsibility Principle (SRP) says that each class should be responsible for exactly one thing. Do your classes follow SRP? What responsibilities do they have?	yes, my planet class has the responsibility of creating an instance of a planet and a summary about this planet. My solar system has the responsibility of returning information about the planets on its system and adding planets to its system. Planet class has responsibilities of creating and storing information about planets, and the solar system has the responsibility of returning information about its system.
How did you organize your require statements? Which files needed requires, and which did not? What is the pattern?	the main.rb file needs require_relative commands to access the classes for the planet and solar system in order to use the methods from these classes and pass information from one class to another. The planet.rb and solar_system.rb did not need require_relative because they don't use the methods outside its own class.

[CheezItMan]

Solar System

What We're Looking For

Feature	Feedback
Baseline
Whitespace (indentation, vertical space, etc)	Good
Variable names	Good
Git hygiene	More commit messages and make your commit messages about the functionality involved NOT the wave completed.
Planet
initialize method stores parameters as instance variables with appropriate reader methods	Check
summary method returns a string	Check
SolarSystem
initialize creates an empty list of planets	Check
add_planet takes an instance of Planet and adds it to the list	Check
list_planets returns a string	Check, nice use of map
find_planet_by_name returns the correct instance of Planet	Nice use of select
CLI
Can list planets and quit	Check
Can show planet details	Check
Can add a planet	Check
Complex functionality is broken out into separate methods	You should really break up that method!
Overall	Nice work, you hit all the learning goals. Look at my inline comments and let me know if you have questions. Great job!

[CheezItMan]

This method begs to be broken up into smaller simpler methods.

[CheezItMan]

This should be above initialize and below class Planet

[CheezItMan]

ditto with above

[CheezItMan]

sweet 👍

[CheezItMan]

Awesome 🥇