Trang Frego - SolarSystem

[tfrego]

Solar System

Congratulations! You're submitting your assignment.

Comprehension Questions

Question	Answer
When does the initialize method run? What does it do?	It runs in the Class block of code to set instance variables.
Why do you imagine we made our instance variables readable but not writable?	We made it readable so we can access the instance variables in Main.rb but made it not writable so that the data is not overwritten.
How would your program be different if each planet was stored as a Hash instead of an instance of a class?	My program would be one large file without the flexibility of breaking them into individual files and calling methods in those files.
How would your program be different if your SolarSystem class used a Hash instead of an Array to store the list of planets?	The SolarSystem class could contain all the information of each planet within the hash.
The Single Responsibility Principle (SRP) says that each class should be responsible for exactly one thing. Do your classes follow SRP? What responsibilities do they have?	Yes, the SolarSystem class is responsible for only information pertinent to its solar system which is the star and planets. The Planet class has information specific to the individual planets.
How did you organize your require statements? Which files needed requires, and which did not? What is the pattern?	I organized my 'require' statements with the needed classes first then the gems. The files needed depended on whether I was using the classes and gems in the following code.

[CheezItMan]

Solar System

What We're Looking For

Feature	Feedback
Baseline
Whitespace (indentation, vertical space, etc)	Check
Variable names	Check
Git hygiene	Good number of commits and good commit messages
Planet
initialize method stores parameters as instance variables with appropriate reader methods	Check
summary method returns a string	Check
SolarSystem
initialize creates an empty list of planets	Check
add_planet takes an instance of Planet and adds it to the list	Check
list_planets returns a string	Check
find_planet_by_name returns the correct instance of Planet	Check
CLI
Can list planets and quit	Check
Can show planet details	Check
Can add a planet	Check
Complex functionality is broken out into separate methods	Good, but it could be broken up more.
Overall	Very nice work, you hit all the learning goals and the distance extra. Great work!

[CheezItMan]

You can probably break up this method a bit more

[CheezItMan]

You don't need the else, the raise will exit the method anyway

[CheezItMan]

You could also use .find which returns the first one that matches and nil if nothing matches.

[CheezItMan]

Nice! 🥇