Solar System - Leanne R

[leannerivera]

Solar System

Congratulations! You're submitting your assignment.

Comprehension Questions

Question	Answer
When does the initialize method run? What does it do?	It creates a new instance of the class, runs immediately with . new
Why do you imagine we made our instance variables readable but not writable?	so user cannot edit any of the information outside of the program
How would your program be different if each planet was stored as a Hash instead of an instance of a class?	creating new planets would be pushing a smaller hash into an array. also, keywords will be used to get data instead of methods. methods would have to be defined in the main code.
How would your program be different if your SolarSystem class used a Hash instead of an Array to store the list of planets?	would be easier to find planet information, can just search keyword 'name' to see if name is there. easier to pull info when key or value is known
The Single Responsibility Principle (SRP) says that each class should be responsible for exactly one thing. Do your classes follow SRP? What responsibilities do they have?	one class is for everything to do with the Solar system, while the other is for the planets that go into the solar system. the requirements and methods for both classes are distinct.
How did you organize your require statements? Which files needed requires, and which did not? What is the pattern?	when a cross-reference was needed, require is needed, eg for the main.rb which needs info on both planet and solarsystem, a reference to both files are imperative. solar system only requires access to planet because it utilizes information from instances of that class.

[CheezItMan]

Solar System

What We're Looking For

Feature	Feedback
Baseline
Whitespace (indentation, vertical space, etc)	Good
Variable names	Good
Git hygiene	More commits would be good, and avoid using waves as commit messages, instead focus on the functionality you have added.
Planet
initialize method stores parameters as instance variables with appropriate reader methods	Check
summary method returns a string	Check
SolarSystem
initialize creates an empty list of planets	Check
add_planet takes an instance of Planet and adds it to the list	Check
list_planets returns a string	Check
find_planet_by_name returns the correct instance of Planet	Check
CLI
Can list planets and quit	Check
Can show planet details	Check
Can add a planet	Check
Complex functionality is broken out into separate methods	Nope
Overall	Nice work overall. See my inline comments and let me know any questions you have. You hit all the learning goals. Great work!

[CheezItMan]

Note the Rakefile is looking for a specs folder, but you named it spec (singular).

[CheezItMan]

This method begs to be broken up into smaller methods.

[leannerivera]

Okay, thanks I thought everything had to stay into main, that is the only reason why I didn't. Now I know for future.

[CheezItMan]

You shouldn't need a writer for planets

[leannerivera]

Yes, correct, forgot to delete after tests.

[CheezItMan]

You can also do:

return @planets.find do |planet|
  planet.name.downcase == planet_name.downcase
end