CI #43
Merged
CI #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Port robot_model submodule of moveit_core to ROS 2 * Clean submodule CMakeLists.txt Remove unnecesary commands listed already one level higher * robot_model, simplify CMakeLists.txt Following guidelines provided at moveit#8 (comment) * Fix testing and comment it out for now moveit_resources hasn't been ported just yet * robot_model, cleanup code * Revert changes, reenable properties version * robot_model re-enable tests with moveit_resources ported moveit/moveit_resources#24 this PR re-enables the testing while allowing the submodule to still compile * robot_model submodule, fix logging * robot_model use LOGGER Follow consensus about logging in moveit_core submodules * Remove robot_model log.h * robot_model, apply clang format * moveit_core, robot_model: remove setDefaultIKAttempts
LanderU
approved these changes
Apr 7, 2019
|
LGTM! |
|
I've fixed the test error sin urdfdom_py AcutronicRobotics/urdf_parser_py@ed25658 |
|
I think we're good to go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@LanderU take into account this goes together with AcutronicRobotics/moveit2_ci@0f53118