Allow one to specify server endpoint in config #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErikBjare
reviewed
Jan 31, 2024
aw_client/client.py
Outdated
| protocol=protocol, host=server_host, port=server_port | ||
| ) | ||
| self.server_address = server_config["endpoint"] or default_server_address |
There was a problem hiding this comment.
I think we need a better name than endpoint (which imo is more something like /api/info, or a full path).
I've seen some APIs use baseurl, which I like.
Suggested change
| self.server_address = server_config["endpoint"] or default_server_address | |
| self.server_address = server_config["baseurl"] or default_server_address |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm experimenting running aw-server-rust from my home k8s network, with a tls enabled ingress. However, when I trying point my local aw-client to the server I find no success - the config doesn't seem to allow me to specify an https endpoint address. Peeking into the code seems to indicate that the endpoint is hard-coded by stitching up a default protocol, and the host, port from config.
I guess there is no reason that it cannot support https, so I patched the source code like this. Now it worked perfectly for me. Would you like to accept it to the upstream?