Fix Publish Integration Test #3591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchell-as
previously approved these changes
Nov 13, 2024
| @@ -371,5 +372,20 @@ func (c *Client) runWithFiles(ctx context.Context, gqlReq RequestWithFiles, resp | |||
| if err := json.Unmarshal(resp, &gr); err != nil { | |||
| return errors.Wrap(err, "decoding response") | |||
| } | |||
| return nil | |||
|
|
|||
| if len(intermediateResp) == 1 { | |||
There was a problem hiding this comment.
Nit: a comment describing why this conditional is here or what conditions it may occur under would probably be useful for anyone debugging around this area in the future. However, I recognize the follow up ticket may end up addressing this, so I leave it up to you.
mitchell-as
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now have two graphQL client implementations. I've ported the changes from #3580 into this PR but the real solution will be to unify the client code. I've filed a story for that here: https://activestatef.atlassian.net/browse/DX-3162