Handle more panics #3577
Merged
Handle more panics #3577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
MDrakos
commented
Nov 1, 2024
•
MDrakos
commented
 DX-3136 Rollbar: Could not report messages as CheckMessages return an error: Error sending messages request:
|
MDrakos
commented
Nov 1, 2024
internal/poller/poller.go
Outdated
Comment on lines
24
to
29
| wrappedFn := func() (interface{}, error) { | ||
| defer func() { | ||
| panics.LogAndPanic(recover(), debug.Stack()) | ||
| }() | ||
| return pollFunc() | ||
| } |
There was a problem hiding this comment.
Panics can occur in the goroutine where the poll func is started. If we don't want this automatic wrapping we can update each caller of this library to manually inject it into their pollfunc.
Naatan
requested changes
Nov 5, 2024
internal/poller/poller.go
Outdated
Comment on lines
24
to
29
| wrappedFn := func() (interface{}, error) { | ||
| defer func() { | ||
| panics.LogAndPanic(recover(), debug.Stack()) | ||
| }() | ||
| return pollFunc() | ||
| } |
There was a problem hiding this comment.
I think we need to implement this as part of the pollFunc that we pass. Reason being that if we catch it here the stacktrace won't point to what caused the panic.
Co-authored-by: Nathan Rijksen <[email protected]>
Naatan
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.